dev: Add Keystone embed with Bookmark and Collection #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suzubara
commented
Sep 7, 2021
| @@ -1,6 +1,5 @@ | |||
| module.exports = { | |||
| testPathIgnorePatterns: ['/node_modules/', '.next/', 'cypress/'], | |||
| moduleDirectories: ['node_modules/', '.'], | |||
There was a problem hiding this comment.
This was causing babel transform errors when trying to test Keystone 😕
There was a problem hiding this comment.
what does this change (if anything) moving forward?
There was a problem hiding this comment.
If we add directories under src/ that we want to be able to import from using absolute paths, they'll need to be added to this file so Jest can resolve the imports correctly
suzubara
changed the title
suzubara
commented
Sep 8, 2021
| "storybook-css-modules-preset": "1.1.1", | ||
| "style-loader": "2.0.0", | ||
| "typescript": "4.4.2" | ||
| }, | ||
| "resolutions": { | ||
| "@babel/runtime": "7.15.4" | ||
| }, |
There was a problem hiding this comment.
I ended up updating a bunch of packages because there were some incompatibilities causing Storybook to not run.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds Keystone CMS in embedded mode so that we can develop the portal application against a CMS, prior to standing the CMS up as its own service. This approach is described in this ADR.
The Keystone entrypoint is added at
keystone.ts-- this is where Keystone bootstraps all config, database settings, and the content schema. I added a basic schema for Bookmarks and Collections, as well as some corresponding tests.schema.graphqlandschema.prismaare both generated by Keystone but should be checked into VCS.This also exposes a local URL for viewing the GraphQL API at: http://localhost:3000/api/graphql
I also did a little bit of housekeeping, updating
.eslintignore&.prettierignorefiles.Fixes #78
Review Notes
This has to be tested locally since Keystone-embed only works in local development. To test, check out this branch and run:
This should expose two URLs:
http://localhost:3000/ - the portal site
http://localhost:8000/ - the Keystone admin UI
Verify you can add Bookmarks/Collections as expected. Note that these aren't surfaced in the UI anywhere yet, so there is nothing to test in the portal itself (yet!). If you add content using the admin UI, there should be changes made to the
cms.dbfile.